Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Start voice broadcast recording while listening #9630

Merged
merged 9 commits into from
Nov 30, 2022
Merged

Start voice broadcast recording while listening #9630

merged 9 commits into from
Nov 30, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 28, 2022 •
edited
Loading

Part of element-hq/element-web#23282

start_vb

PSF-1761

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 28, 2022
@weeman1337 weeman1337 marked this pull request as ready for review November 28, 2022 14:46
@weeman1337 weeman1337 requested a review from a team as a code owner November 28, 2022 14:46
germain-gg
germain-gg approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@weeman1337 weeman1337 merged commit 459df45 into develop Nov 30, 2022
@weeman1337 weeman1337 deleted the weeman1337/start-vb-recording-while-listening branch November 30, 2022 10:16
@weeman1337 weeman1337 added the backport staging Label to automatically backport PR to staging branch label Nov 30, 2022
@RiotRobot RiotRobot mentioned this pull request Nov 30, 2022
Merged
RiotRobot pushed a commit that referenced this pull request Nov 30, 2022
@weeman1337 @github-actions
Fix start voice broadcast recording while listening (#9630)
60a18ef 
(cherry picked from commit 459df45)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @germain-gg